jleibl/simple-ai-provider
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

refactor: extract constants, parameterize validators, simplify factory #7

Merged
jleibl merged 1 commits from refactor/quick-wins-factory-validators-constants into main 2026-05-21 11:36:34 +00:00
Conversation 0 Commits 1 Files Changed 8 +163 -253
jleibl commented 2026-05-21 11:36:25 +00:00
Owner
Copy Link

Quick-win refactors from the Refactoring Guru catalog:

  • Replace Magic Number with Symbolic Constant: extract DEFAULT_TIMEOUT_MS,
    DEFAULT_MAX_RETRIES, DEFAULT_MAX_TOKENS, DEFAULT_TEMPERATURE, default
    models per provider, and validation prompt into src/constants.ts.
  • Parameterize Method: collapse validateTemperature / validateTopP /
    validateMaxTokens (and the inline timeout/maxRetries checks) into a
    single validateNumberInRange helper with bounds metadata.
  • Inline Class / Remove Middle Man: drop the unused ProviderRegistry
    class from utils/factory.ts. createProvider now dispatches through
    the PROVIDER_REGISTRY const directly instead of a parallel switch.

Also fixes stale VERSION constant in src/index.ts (was 1.3.1).

Quick-win refactors from the Refactoring Guru catalog: - Replace Magic Number with Symbolic Constant: extract DEFAULT_TIMEOUT_MS, DEFAULT_MAX_RETRIES, DEFAULT_MAX_TOKENS, DEFAULT_TEMPERATURE, default models per provider, and validation prompt into src/constants.ts. - Parameterize Method: collapse validateTemperature / validateTopP / validateMaxTokens (and the inline timeout/maxRetries checks) into a single validateNumberInRange helper with bounds metadata. - Inline Class / Remove Middle Man: drop the unused ProviderRegistry class from utils/factory.ts. createProvider now dispatches through the PROVIDER_REGISTRY const directly instead of a parallel switch. Also fixes stale VERSION constant in src/index.ts (was 1.3.1).
jleibl added 1 commit 2026-05-21 11:36:26 +00:00
refactor: extract constants, parameterize validators, simplify factory bb37e61eaf 
Quick-win refactors from the Refactoring Guru catalog:

- Replace Magic Number with Symbolic Constant: extract DEFAULT_TIMEOUT_MS,
  DEFAULT_MAX_RETRIES, DEFAULT_MAX_TOKENS, DEFAULT_TEMPERATURE, default
  models per provider, and validation prompt into src/constants.ts.
- Parameterize Method: collapse validateTemperature / validateTopP /
  validateMaxTokens (and the inline timeout/maxRetries checks) into a
  single validateNumberInRange helper with bounds metadata.
- Inline Class / Remove Middle Man: drop the unused ProviderRegistry
  class from utils/factory.ts. createProvider now dispatches through
  the PROVIDER_REGISTRY const directly instead of a parallel switch.

Also fixes stale VERSION constant in src/index.ts (was 1.3.1).
jleibl merged commit 8e73296ac2 into main 2026-05-21 11:36:34 +00:00
jleibl deleted branch refactor/quick-wins-factory-validators-constants 2026-05-21 11:36:37 +00:00
jleibl referenced this issue from a commit 2026-05-21 11:54:34 +00:00
chore(release): 2.0.1
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
jleibl
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: jleibl/simple-ai-provider#7
Delete Branch "refactor/quick-wins-factory-validators-constants"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?